Window size doesn't restore if closed when maximised

Fixed in r110

It could be a problem at my side and I don't now if it is related to this.

When using SVNr119 Fahmon didn't popup when I push the trayicon. I see Fahmon displayed on the taskbar but I have to click on the taskbar button to see Fahmon. I have tried this with version 2.3.1, and there it is working normally (also without windowblinds).

Is that when FahMon should appear maximised?

I'll check this again on the Windows build.

Not only when I have maximised the Fahmon window, but also with a resized one.

OK, I agree, there is a problem with the Windows version, which is annoying since it works perfectly on Linux.

This is also an issue on osx. The window size at launch is always the default size.

If I show the log, quit, and relaunch, all I see is the log until I resize or toggle the log.

True, but at the moment the reason for this is that the window size settings are not saved because FahMon never shuts down cleanly.

Well, I see in MainDialog::OnClose(), that it will only save its frame if win32 and not iconized:

	// Don't save window size if it is iconized (win32 bug)
#ifdef _FAHMON_WIN32_
	if(!IsIconized())
	{
		// Save the size of the frame
		_PrefsSetInt(PREF_MAINDIALOG_FRAMEWIDTH,  GetSize().GetWidth());
		_PrefsSetInt(PREF_MAINDIALOG_FRAMEHEIGHT, GetSize().GetHeight());

		// Save the position of the frame
		_PrefsSetInt(PREF_MAINDIALOG_FRAME_POS_X, GetPosition().x);
		_PrefsSetInt(PREF_MAINDIALOG_FRAME_POS_Y, GetPosition().y);
	}
#endif

I think you want this:

	// Don't save window size if it is iconized (win32 bug)
#ifdef _FAHMON_WIN32_
	if(!IsIconized())
#endif
	{
		// Save the size of the frame
		_PrefsSetInt(PREF_MAINDIALOG_FRAMEWIDTH,  GetSize().GetWidth());
		_PrefsSetInt(PREF_MAINDIALOG_FRAMEHEIGHT, GetSize().GetHeight());

		// Save the position of the frame
		_PrefsSetInt(PREF_MAINDIALOG_FRAME_POS_X, GetPosition().x);
		_PrefsSetInt(PREF_MAINDIALOG_FRAME_POS_Y, GetPosition().y);
	}

Good catch, however this is already fixed in trunk: source:trunk/src/mainDialog.cpp which has been updated.

At the moment the only thing wrong with the code is that on wxmsw the Window isn't raised when you click on the tray icon (whereas it is on wxgtk, not sure about wxmac, since I haven't copied the code to the mac branch yet). The size restoring ability works correctly.

The ifdef is only present in the mactest branch in that for so I could guarantee that it wasn't interfering with the client quit process. Once I copy the most recent trunk changes into the mactest branch, these things should work.

Finally fixed (and tested) in r134